Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] metadata issues [Add] better metadata tests #23

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[Fix] metadata issues [Add] better metadata tests #23

merged 1 commit into from
Nov 29, 2023

Conversation

g5t
Copy link
Collaborator

@g5t g5t commented Nov 29, 2023

Fixes #22 plus a few other issues found in MetaData parsing

  • The Comp visitor did not strip double quotes from StringLiteral mimetype and name values, but the Instr/Instance visitor did. Now all variants strip the surrounding quotes (if a name has spaces, the quotes get added back for C output purposes).
  • The Instance visitor incorrectly identified the source of any MetaData as coming from a component definition file
  • The Instance visitor also incorrectly identified the source name of any MetaData as the name of the metadata.

@g5t g5t merged commit 2b7777d into main Nov 29, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetaData creation static methods mix-up name and mimetype properties.
1 participant